Fix tag logic in build script#225
Merged
Merged
Conversation
padelsbach
reviewed
Jul 22, 2025
padelsbach
reviewed
Jul 23, 2025
padelsbach
previously approved these changes
Jul 23, 2025
ColtonWilley
approved these changes
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Our nightly's are failing here with wolfssl master because the current tag is
v5.8.2-stablewhile it is expecting master. This changes the logic so it prioritizesgit branch --show-currentfor master andgit describe --tagsfor*-stable || v*. It will fall back if none of those work to the opposite just like it did before.b077c81eb635392e694ccedbab8b644297ec0285orb077c81when building by settingWOLFSSL_TAGorOPENSSL_TAGwith the commit.